Mark Dain On Thursday I called out a co-worker on some bad code he'd written on the front end and that caused some tension in the office. What is the best approach to letting people know they need to write more maintainable code and stick to accepted conventions (everyone else uses tabs, he uses spaces). Stuff like that, it's small but it really drags down the quality which we're trying to raise.
Login or register your account to reply
Reverendshaft In our development department, we have an open peer review culture, where other developers are /expected/ to raise concerns over the code other developers present. It's not uncommon for an intern to question a lead developer's work, and it raises the bar without putting any one person under an uncommon level of scrutiny.
7y, 24w 1 reply
Mark Dain That's a really nice approach. I wish we had that at my office. We're working towards implementing version control so I'm hoping peer review will become more common.
7y, 24w reply
Martijn Get around the table and create a company-wide style guide. That way you are not singling out any one specific. It is pretty common praftice nowadays to have one. Possibly enforce parts of it, like indentations, using ".editorconfig" setting files.
7y, 24w 1 reply
Mark Dain I wasn't singling out a co-worker (I sent an email to developers@) but it still caused a bit of trouble.
7y, 24w reply