Eric
abcz.co.uk/rtl-watch Constructive criticism please?
7y, 34w
15 replies
¬
Nkrs
I think I've already said it, but here it goes again - that's one nice looking website altogether. One suggestion though: you might want to resize and compress that starry background image, it's over 16MB in size.
7y, 34w
3 replies
🦿 Lucian Marin
@eric should crop the sky part and save it as PNG. It's no more than a black background and some white dots. Compress it with ImageOptim at the end.
7y, 34w
1 reply
🦿 Lucian Marin
Why don't you package the command line too? You run it using a relative path or you determine the path from inside the app.
7y, 34w
6 replies
Mark Dain
Much better idea actually! I completely forgot ImageOptim does the same thing
7y, 34w
1 reply
Martijn
librtlsdr is GPL licensed, so I don't think you are allowed to bundle, unless @eric makes his application available under GPL as well. This is one of the reasons LGPL was created: LGPL licensed software may be used inside proprietary software without the "viral" spread of GPL.
7y, 34w
2 replies
Eric
I emailed rtl-sdr.com who despite not being the creators of rtl_sdr are the main leads in documenting the software in the field. They recommended I do not bundle at all and/or instead follow the method SDR# (SDR Sharp) uses of bundling a download script which fetches all the required software. I'd rather not get my hands mucky with licensing issues and have left it to the user to ensure they have the required software. cc @martijnvdven
7y, 34w
reply
Mark Dain
Is this something you built? If so, it looks really amazing! Well done! I'd love to hear your experiences building with Cocoa+Swift. Now for constructive feedback: I'd look into getting the app signed so you're an identified developer, otherwise I have to whitelist in Gatekeeper. If you don't have the command line app installed, it seems to not open :( You could check for it in $PATH and if it's not there, display a helpful error message with a link/instructions to download. Otherwise it's good. Perhaps there's some aesthetic improvements that can be made on the preferences window but I can't really comment on that.
7y, 34w
1 reply
Eric
@ancarda Yeah, built upon the command-line app rtl_power, cheers! Been really fun building it, though a bit messy since this was my first time really giving Swift a good go (best way to learn is by building a project right?). I've fixed the issue you found, now if you don't have rtl_sdr installed it will open but tell you off, I'll improve the error message at a later date (I'm ill right now so I'm not gonna be writing documentation lol). The aesthetics of the preferences window are gross but there's not much else I can think of doing with it.
7y, 34w
reply
Martijn
No criticisms, as I have no use for the app itself. But happy to see another Caffeine user! And I really like your (new?) homepage design!
7y, 34w
1 reply
Eric
Haha, I was fishing for criticism of the app and the page itself. Caffeine is great, always had it around as long as I can remember, even back on Snow Leopard. The homepage has had a colour change, from gloomy purple to that gross (but lovely) lobster scheme. I was getting fed up with how dark it looked.
7y, 34w
reply